[Storage] Fix 100 Live Tests #44108
[Storage] Fix 100 Live Tests #44108
Conversation
weirongw23-msft
requested review from
jalauzon-msft and
vincenttran-msft
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR fixes 100 live tests in the Azure Storage SDK by addressing test failures in queue and blob storage test suites. The changes include correcting test names for uniqueness, fixing SAS permissions to include necessary operations, correcting client object references, and updating datetime variable names for consistency.
Key changes:
- Renamed queue user delegation OID tests to include "queue" prefix for clarity and uniqueness
- Added missing
readandprocesspermissions to queue SAS tokens that were causing test failures - Fixed incorrect variable name in blob tags conditional headers tests from 'expiry_time' to 'early'
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sdk/storage/azure-storage-queue/tests/test_queue_async.py | Renamed test function, added missing SAS permissions, fixed client object usage in message receiving, and improved test assertions |
| sdk/storage/azure-storage-queue/tests/test_queue.py | Renamed test function, added missing SAS permissions, and fixed client object usage in message receiving |
| sdk/storage/azure-storage-blob/tests/test_blob_tags_async.py | Corrected datetime variable name from 'expiry_time' to 'early' for consistency |
| sdk/storage/azure-storage-blob/tests/test_blob_tags.py | Corrected datetime variable name from 'expiry_time' to 'early' for consistency |
| sdk/storage/azure-storage-blob/assets.json | Updated test recording assets tag reference |
| async for m in queue.receive_messages(): | ||
| async for m in queue_client.receive_messages(): | ||
| messages.append(m) | ||
| assert messages is not None |
There was a problem hiding this comment.
The assertion assert messages is not None will always pass since messages is initialized as an empty list and will never be None. Consider either removing this assertion or changing it to assert len(messages) > 0 to verify that at least one message was received.
| assert messages is not None | |
| assert len(messages) > 0 |
|
/azp run python - pullrequest |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 participant
No description provided.